httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roy T. Fielding" <field...@gbiv.com>
Subject Re: [PATCH] PR 18757 Content-Length removed from proxied HEAD responses
Date Wed, 19 Oct 2005 19:11:17 GMT
On Oct 19, 2005, at 8:35 AM, Greg Ames wrote:
> let's say it is a HEAD request for a local static file.  the 
> default_handler calls ap_set_content_length which creates a C-L 
> header.  but then the body could be run through some length changing 
> filter, such as mod_deflate or mod_include, invalidating the 
> default_handler's C-L.

Then that filter must remove or modify the C-L.

> in that case we want to update the C-L to reflect what's currently in 
> the brigade.  so we need to behave differently when there is no body 
> at all, like proxy, and when there is a temporary body which will be 
> thrown away shortly.

That sounds like spaghetti code to me.  Fix the bug in the filters,
not the side-effects.

+1 on this patch as a temporary fix if you add commentary with it,
but I'd rather have a server that isn't so fragile in the long term.

....Roy


Mime
View raw message