httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Akins <bak...@web.turner.com>
Subject Re: [PATCH] ProxyVia Full honor ServerTokens
Date Fri, 28 Oct 2005 13:40:07 GMT
Can we get a vote on this?



Brian Akins wrote:
> Paul Querna wrote:
> 
>> Brian Akins wrote:
>>
>>> It seems no matter what the setting of ServerTokens, mod_proxy uses 
>>> something like this when ProxyVia is set to Full:
>>>
>>> Via: 1.1 i.cnn.net (Apache/2.1.8)
>>>
>>> Should this honor ServerTokens?
>>>
>>>
>>
>> Yes.
>>
> 
> 
> --- mod_proxy_http.c.orig       2005-09-26 11:43:45.893872108 -0400
> +++ mod_proxy_http.c    2005-09-26 12:06:48.390005516 -0400
> @@ -641,7 +641,7 @@
>                                          HTTP_VERSION_MAJOR(r->proto_num),
>                                          HTTP_VERSION_MINOR(r->proto_num),
>                                          server_name, server_portstr,
> -                                        AP_SERVER_BASEVERSION)
> +                                        ap_get_server_version())
>                           : apr_psprintf(p, "%d.%d %s%s",
>                                          HTTP_VERSION_MAJOR(r->proto_num),
>                                          HTTP_VERSION_MINOR(r->proto_num),
> @@ -1296,7 +1296,7 @@
> 
> HTTP_VERSION_MINOR(r->proto_num),
>                                             server_name,
>                                             server_portstr,
> -                                           AP_SERVER_BASEVERSION)
> +                                           ap_get_server_version())
>                                       : apr_psprintf(p, "%d.%d %s%s",
> 
> HTTP_VERSION_MAJOR(r->proto_num),
> 
> HTTP_VERSION_MINOR(r->proto_num),
> 
> 


-- 
Brian Akins
Lead Systems Engineer
CNN Internet Technologies

Mime
View raw message