httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Paul Querna <c...@force-elite.com>
Subject Re: svn commit: r321449 - in /httpd/mod_mbox/trunk/module-2.0: mod_mbox_file.c mod_mbox_index.c
Date Sat, 15 Oct 2005 19:08:15 GMT
André Malo wrote:
> * pquerna@apache.org wrote:
> 
>> -	if (r->header_only)
>> -	    status = OK;
>> +	if (r->header_only) {
>> +	    return OK;
>> +        }
> 
> Actually I think, any code that checks for header_only is wrong. The core 
> will take care of it. Not treating HEAD requests special ensures, that the 
> RFC is fullfilled (HEAD == GET but without a body, in particular the 
> headers remain the same).

Except when we get a HEAD request, r->path_info is filled with bogus 
data, which causes mod_mbox to crash way deep inside itself.

-Paul

Mime
View raw message