httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@algroup.co.uk>
Subject Re: svn commit: r220307 - in /httpd/httpd/trunk/modules: metadata/mod_setenvif.c ssl/mod_ssl.c ssl/mod_ssl.h ssl/ssl_expr_eval.c
Date Mon, 10 Oct 2005 09:48:45 GMT
David Reid wrote:
> Joe Orton wrote:
> 
>>On Fri, Aug 05, 2005 at 08:00:01PM +0200, Martin Kraemer wrote:
>>
>>
>>>On Tue, Aug 02, 2005 at 07:14:10PM +0200, Martin Kraemer wrote:
>>>
>>>
>>>>I wanted something like
>>>>
>>>> SSLRequire "committers" in SSLPeerExtList("1.3.6.1.4.1.18060.1");
>>>>
>>>>to mean "at least one extension with an OID of
>>>>1.3.6.1.4.1.18060.1 with a value of 'committers' exists in the
>>>>client cert".
>>>
>>>I'll be on vacation next week, and will send in another patch after
>>>that.
>>
>>
>>OK, hope you had a good holiday.  I wasn't trying to argue about the 
>>semantics just to nitpick the naming.  Having "SSL" in the SSLRequire 
>>function is redundant, but not in the context of mod_setenvif.  So, my 
>>preference is:
>>
>>    SSLRequire "committers" in PeerExtList("1.3.6.1.4.1.18060.1");
>>
>>    SetEnvIf SSL_PeerExtList("etc") ...
> 
> 
> +1 on the revised naming.
> 
> Patch looks OK as well.

Late to the party here, but giving the same function two different names 
sucks! Or am I misunderstanding?

Cheers,

Ben.

-- 
http://www.apache-ssl.org/ben.html       http://www.thebunker.net/

"There is no limit to what a man can do or how far he can go if he
doesn't mind who gets the credit." - Robert Woodruff

Mime
View raw message