httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Akins <brian.ak...@turner.com>
Subject Re: [PATCH] Re: Pluggable mod_log_config
Date Mon, 03 Oct 2005 19:40:48 GMT
Ondrej Sury wrote:

> Just quick thought, maybe we should add:
> 
> ap_log_writer_close *close;
> 
> to struct log_provider_t.  It's not absolutely necessary, because you
> can use apr_pool_cleanup_register(...), but it will make writing addon
> modules much cleaner.

That's debatable.  I already use apr_pool_cleanup_register in a lot of 
stuff, so it seems "natural" to me.  I guess we could register a cleanup 
  on each cls that called close or we could let the module developer do 
it...  I'm leaning toward just letting others register the cleanup on 
there own like buffered logs does now.


-- 
Brian Akins
Lead Systems Engineer
CNN Internet Technologies

Mime
View raw message