httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Colm MacCarthaigh <c...@stdlib.net>
Subject Re: APR version of support/logresolve.c
Date Mon, 24 Oct 2005 12:12:02 GMT
On Mon, Oct 24, 2005 at 12:58:21PM +0100, Joe Orton wrote:
> - odd style in places, some "if("/"while(" without enough whitespace

Ahh that old habit.

> and declarations with too much whitespace:
>   apr_file_t         * etc;

This comes directly from the old logresolve.c.  Didn't want to change
absolutely everything ;-) But I'll make consistent and less wasteful.

> - apr_hash_* can use APR_HASH_KEY_STRING rather than strlen(key)
> - odd casts to/from (const void *) in hash handling which shouldn't
> be necessary?

No, they're not. I've forgotten why I even have them. Thanks for
spotting them.

-- 
Colm MacCárthaigh                        Public Key: colm+pgp@stdlib.net

Mime
View raw message