httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ondrej Sury <ond...@sury.org>
Subject Re: [PATCH] Re: Pluggable mod_log_config
Date Mon, 03 Oct 2005 19:32:20 GMT
On Mon, 2005-10-03 at 11:40 -0400, Brian Akins wrote:
> Akins, Brian wrote:
> 
> > CustomLog mysql://something common env=images
> > CustomLog file:///logs/my.log combined
> > CustomLog spread://somegroup refere
> > CustomLog buffer:///logs/other.log common
> 
> 
> This patch implements the above.  Within mod_log_config two providers
> are provided: file and buffer.  If no "scheme" is given, file is assumed.
> 
> I have tested and preliminarily it works for both file and buffer.  I
> had to rearrange some of the buffer code to get it to work "non-globally."
> 
> It should be just as easy to write custom log handles. With this patch,
> different custom loggers could handle different log "files."
> 
> Comments?

Wow, you're fast :-).

Just quick thought, maybe we should add:

ap_log_writer_close *close;

to struct log_provider_t.  It's not absolutely necessary, because you
can use apr_pool_cleanup_register(...), but it will make writing addon
modules much cleaner.

Ondrej.
-- 
Ondrej Sury <ondrej@sury.org>

Mime
View raw message