Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 86015 invoked from network); 22 Sep 2005 17:40:44 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 22 Sep 2005 17:40:44 -0000 Received: (qmail 36473 invoked by uid 500); 22 Sep 2005 17:40:26 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 36398 invoked by uid 500); 22 Sep 2005 17:40:25 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 36385 invoked by uid 99); 22 Sep 2005 17:40:25 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Sep 2005 10:40:25 -0700 X-ASF-Spam-Status: No, hits=0.4 required=10.0 tests=DNS_FROM_RFC_ABUSE X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [137.65.81.172] (HELO lucius.provo.novell.com) (137.65.81.172) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Sep 2005 10:40:33 -0700 Received: from INET-PRV1-MTA by lucius.provo.novell.com with Novell_GroupWise; Thu, 22 Sep 2005 11:40:03 -0600 Message-Id: <433297B1.6720.00AC.0@novell.com> X-Mailer: Novell GroupWise Internet Agent 7.0 Date: Thu, 22 Sep 2005 11:39:47 -0600 From: "Brad Nicholes" To: Subject: Re: [PATCH 36563] Backported patch invalid handling of NULL values in mod_ldap caching References: <1127135051.8595.105.camel@maple.active24.cz> In-Reply-To: <1127135051.8595.105.camel@maple.active24.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N This patch is sitting in the STATUS file waiting for one more vote. It sure would be nice to get it into the 2.0.55 release. Anyone willing to give it a quick review? Brad >>> ondrej@sury.org 9/19/2005 >>> Hello, attached is backported patch from 2.1-BETA7 which fixes invalid handling of NULL values in mod_ldap caching code. There is an open bug in bugzilla: http://issues.apache.org/bugzilla/show_bug.cgi?id=36563 And this is just updated patch against today SVN checkouted 2.0.x (patch from bugzilla applies ok with offset of 20 lines). Hopefully this gets accepted before 2.0.55 is out, since this bug can cause memory leaks in util_ldap_search_node_free (not all items are freed only those before first item with NULL value). Ondrej. -- Ondrej Sury