Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: neutral (asf.osuosl.org: local policy)
Message-ID: <431F6779.5080406@rowe-clan.net>
Date: Wed, 07 Sep 2005 17:19:37 -0500
From: "William A. Rowe, Jr." <wrowe@rowe-clan.net>
User-Agent: Mozilla Thunderbird 1.0.6-1.1.fc3 (X11/20050720)
MIME-Version: 1.0
To: dev@httpd.apache.org
CC: cvs@httpd.apache.org
Subject: Re: svn commit: r278652 - in /httpd/httpd/branches/async-dev: CHANGES
 include/ap_mpm.h include/util_filter.h server/core.c
 server/mpm/experimental/event/Makefile.in
 server/mpm/experimental/event/event.c
 server/mpm/experimental/event/event_filters.c
References: <20050905002132.34408.qmail@minotaur.apache.org>
In-Reply-To: <20050905002132.34408.qmail@minotaur.apache.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

pquerna@apache.org wrote:
> Author: pquerna
> Date: Sun Sep  4 17:21:25 2005
> New Revision: 278652
> 
> URL: http://svn.apache.org/viewcvs?rev=278652&view=rev
> Log:
> *) Create an optional function and MPM Query to replace the core output filter.
> *) Put an example of using it into the Event MPM, which just calls the original core output filter.  
> 
> Modified: httpd/httpd/branches/async-dev/CHANGES
> URL: http://svn.apache.org/viewcvs/httpd/httpd/branches/async-dev/CHANGES?rev=278652&r1=278651&r2=278652&view=diff
>  
> +  *) Enable MPMs to easily override the core output filter.
> +     [Paul Querna]
> +
> Modified: httpd/httpd/branches/async-dev/include/ap_mpm.h
> URL: http://svn.apache.org/viewcvs/httpd/httpd/branches/async-dev/include/ap_mpm.h?rev=278652&r1=278651&r2=278652&view=diff
> ==============================================================================
> @@ -146,6 +146,7 @@
> +#define AP_MPMQ_CUSTOM_WRITE         15  /* MPM uses a custom output filter */

BLEH!!!  It's none of anyone's business *WHAT* the 'core output filter'
actually is!!!

If a module has made some assumptions, they should walk the filter stack
themselves.

Please revert this portion of the change; any respectible filter must
remain agnostic to the current state of the protocol filters.


Bill