Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (asf.osuosl.org: domain of jorton@redhat.com designates
 66.187.233.31 as permitted sender)
Date: Wed, 21 Sep 2005 15:03:11 +0100
From: Joe Orton <jorton@redhat.com>
To: dev@httpd.apache.org
Subject: Re: svn commit: r290672 - in /httpd/httpd/trunk/modules: database/
 database/Makefile.in database/config.m4 database/mod_dbd.c database/mod_dbd.h
 experimental/mod_dbd.c experimental/mod_dbd.h
Message-ID: <20050921140311.GA4929@redhat.com>
Mail-Followup-To: dev@httpd.apache.org
References: <20050921100406.90405.qmail@minotaur.apache.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20050921100406.90405.qmail@minotaur.apache.org>
User-Agent: Mutt/1.4.2.1i

On Wed, Sep 21, 2005 at 10:04:05AM -0000, niq@apache.org wrote:
> Author: niq
> Date: Wed Sep 21 03:04:00 2005
> New Revision: 290672
> 
> URL: http://svn.apache.org/viewcvs?rev=290672&view=rev
> Log:
> Move mod_dbd from /experimental/ to /database/

That broke the build, the duplicated APACHE_MODULE meant it was trying 
to build mod_dbd in both old and new locations; here are the new gcc 
warnings since this gets enabled by default now:

mod_dbd.c: In function 'ap_dbd_open':
mod_dbd.c:301: warning: dereferencing type-punned pointer will break strict-aliasing rules
mod_dbd.c:310: warning: dereferencing type-punned pointer will break strict-aliasing rules
mod_dbd.c:316: warning: 'rv' is used uninitialized in this function

    ap_dbd_t *rec = NULL;
...  
    rv = dbd_construct((void**)&rec, svr, pool);

should be e.g.:

    ap_dbd_t *rec;
    void *vrec = NULL;

    dbd_construct(&vrec, ...);

    rec = vrec;

This really needs a configure-time apr-util version check too since it's 
quite possible to build against apr-util 1.0 otherwise.

Regards,

joe