httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: svn commit: r292397 - /httpd/httpd/branches/2.0.x/server/core.c
Date Thu, 29 Sep 2005 07:14:49 GMT
Although it took two commits, please comment on the following patch to
eliminate an 'unused variable' rv in some cases (happy to back out if
there are objections);

Index: server/core.c^M
===================================================================
--- server/core.c       (revision 292396)
+++ server/core.c       (working copy)
@@ -4485,9 +4485,10 @@
  static int core_pre_connection(conn_rec *c, void *csd)
  {
      core_net_rec *net = apr_palloc(c->pool, sizeof(*net));
+
+#ifdef AP_MPM_DISABLE_NAGLE_ACCEPTED_SOCK
      apr_status_t rv;

-#ifdef AP_MPM_DISABLE_NAGLE_ACCEPTED_SOCK
      /* BillS says perhaps this should be moved to the MPMs. Some OSes
       * allow listening socket attributes to be inherited by the
       * accept sockets which means this call only needs to be made

Thanks,

Bill

Mime
View raw message