httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: svn commit: r289593 - /httpd/httpd/branches/2.2.x/os/unix/os.h
Date Fri, 16 Sep 2005 17:15:50 GMT
Joe Orton wrote:
> On Fri, Sep 16, 2005 at 04:07:04PM -0000, William Rowe wrote:
> 
>>Author: wrowe
>>Date: Fri Sep 16 09:07:01 2005
>>New Revision: 289593
>>
>>URL: http://svn.apache.org/viewcvs?rev=289593&view=rev
>>Log:
>>
>>  I'd prefer, before 2.2-final, to have AP_NEED_SET_MUTEX_PERMS defined
>>  across all architectures as 1|0.  Comments?
> 
> -0, it's a bikeshed which doesn't need repainting.

Actually, if you are the author of mod_foo (mod_jk, for example) and you
intend to compile against either httpd-2.0 or 2.2, it's quite useful.

I suppose it's possible to add all the versioning tests and use the
platform flags for 2.0 builds; but simply trusting that the value of
AP_NEED_SET_MUTEX_PERMS is correct, if defined, will simplify the rest
of the logic.  E.g...

#ifdef AP_NEED_SET_MUTEX_PERMS
# define JK_NEED_SET_MUTEX_PERMS AP_NEED_SET_MUTEX_PERMS
#else
   /* A special case for httpd-2.0 */
# if !defined(OS2) && !defined(WIN32) && !defined(BEOS) && !defined(NETWARE)
#  define JK_NEED_SET_MUTEX_PERMS 1
# else
#  define JK_NEED_SET_MUTEX_PERMS 0
# endif
#endif


Bill

Mime
View raw message