httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From André Malo ...@perlig.de>
Subject Re: [PATCH] Fix c2x/ap_escape_logitem ugliness
Date Tue, 27 Sep 2005 21:12:04 GMT
* Justin Erenkrantz wrote:

> [ moving this from dev@subversion.tigris.org to dev@httpd. For those not
> on the Subversion lists, Subversion has an issue with escaping the
> contents of the httpd log. ]
>
> --On September 27, 2005 7:17:59 PM +0200 André Malo <nd@perlig.de> wrote:
> > Only \xx is used. Well, c2x is utilized, but the logging escaper
> > replaces the % with an x and precedes the whole sequence with an \ (->
> > \xhh). See ap_escape_logitem in server/util.c.
>
> Ugh.  What a fugly function.  c2x does set it to '%hh', but
> ap_escape_logitem goes and changes the % to an x.
>
> So, any objections to this patch?

No, +1.

nd
-- 
> Rätselnd, was ein Anthroposoph mit Unterwerfung zu tun hat...
                    ^^^^^^^^^^^^
[...] Dieses Wort gibt so viele Stellen für einen Spelling Flame her, und
Du gönnst einem keine einzige.    -- Jean Claude und David Kastrup in dtl

Mime
View raw message