httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: svn commit: r289593 - /httpd/httpd/branches/2.2.x/os/unix/os.h
Date Fri, 16 Sep 2005 17:41:11 GMT
On Fri, Sep 16, 2005 at 12:15:50PM -0500, William Rowe wrote:
> Joe Orton wrote:
> >On Fri, Sep 16, 2005 at 04:07:04PM -0000, William Rowe wrote:
> >> I'd prefer, before 2.2-final, to have AP_NEED_SET_MUTEX_PERMS defined
> >> across all architectures as 1|0.  Comments?
> >
> >-0, it's a bikeshed which doesn't need repainting.
> 
> Actually, if you are the author of mod_foo (mod_jk, for example) and you
> intend to compile against either httpd-2.0 or 2.2, it's quite useful.
> 
> I suppose it's possible to add all the versioning tests and use the
> platform flags for 2.0 builds; but simply trusting that the value of
> AP_NEED_SET_MUTEX_PERMS is correct, if defined, will simplify the rest
> of the logic.  E.g...

Sounds reasonable, +0 then but please wait until it's been reviewed 
before putting it on the 2.2.x branch.

joe

Mime
View raw message