Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (asf.osuosl.org: local policy)
Errors-To: <wrowe@rowe-clan.net>
Message-Id: <6.2.1.2.2.20050809100222.06fd1b30@pop3.rowe-clan.net>
Date: Tue, 09 Aug 2005 11:40:36 -0500
To: dev@httpd.apache.org
From: "William A. Rowe, Jr." <wrowe@rowe-clan.net>
Subject: Re: svn commit: r230733 -
  /httpd/httpd/trunk/modules/proxy/mod_proxy_http.c
Cc: dev@httpd.apache.org, cvs@httpd.apache.org
In-Reply-To: <20050809093859.GB30302@redhat.com>
References: <20050808025136.14373.qmail@minotaur.apache.org>
 <6.2.1.2.2.20050808004803.070542c0@pop3.rowe-clan.net>
 <20050809093859.GB30302@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"

At 04:38 AM 8/9/2005, Joe Orton wrote:

>Great, yes with last night's regression run the segfaults with worker 
>were gone and the tests are all passing for prefork and worker again on 
>the trunk - thanks a lot Bill.  -Werror builds are failing though:
>
>mod_proxy_http.c: In function `ap_proxy_http_request':
>mod_proxy_http.c:312: warning: 'status' might be used uninitialized in 
>this function

Does this patch resolve status for your compiler's -Werror?
(already committed to trunk, will hold off on proxyreq-2.0.x
till I hear back.)

--- httpd/httpd/trunk/modules/proxy/mod_proxy_http.c (original)
+++ httpd/httpd/trunk/modules/proxy/mod_proxy_http.c Tue Aug  9 07:54:46 2005
@@ -949,7 +949,8 @@
                                               || (bytes_read > 0));
         break;
     default:
-        ap_assert(1 != 1);
+        /* shouldn't be possible */
+        status = APR_EINVAL;
         break;
     }