Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 2117 invoked from network); 25 Aug 2005 17:38:28 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 25 Aug 2005 17:38:28 -0000 Received: (qmail 5058 invoked by uid 500); 25 Aug 2005 17:38:24 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 4989 invoked by uid 500); 25 Aug 2005 17:38:23 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 4976 invoked by uid 99); 25 Aug 2005 17:38:23 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Aug 2005 10:38:23 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [204.146.167.214] (HELO Boron.MeepZor.Com) (204.146.167.214) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Aug 2005 10:38:41 -0700 Received: from remulak.net (dmz-firewall [206.199.198.4]) by Boron.MeepZor.Com (8.12.8/8.12.8) with ESMTP id j7PHcLhL029120 for ; Thu, 25 Aug 2005 13:38:22 -0400 Message-ID: <430DC7FD.2080909@remulak.net> Date: Thu, 25 Aug 2005 09:30:37 -0400 From: Greg Ames User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4.3) Gecko/20041004 X-Accept-Language: en MIME-Version: 1.0 To: dev@httpd.apache.org Subject: Re: TCP_CORK in Linux 2.6: not broken, but it doesn't work with TCP_NODELAY References: In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Brian Pane wrote: > Rather than automatically setting TCP_NODELAY in core_pre_connection(), > perhaps we should set it conditionally in core_output_filter(), where > we have > enough information to tell whether it's needed. I'm +1 on the concept of being more lazy about setting the sockopts. the way we do it now on Linux is pretty silly. we set it one way, discover we're doing sendfile and change our minds and flip it the other way, then set another option, then undo that and go back to step 1. these syscalls seem cheap on Linux but half of them could be eliminated. doing so might bypass the 2.6 cork bug. Greg