Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 14700 invoked from network); 23 Aug 2005 03:43:33 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 23 Aug 2005 03:43:33 -0000 Received: (qmail 65265 invoked by uid 500); 23 Aug 2005 03:43:29 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 65221 invoked by uid 500); 23 Aug 2005 03:43:29 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 65208 invoked by uid 99); 23 Aug 2005 03:43:29 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Aug 2005 20:43:29 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: local policy) Received: from [209.68.5.17] (HELO relay03.pair.com) (209.68.5.17) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 22 Aug 2005 20:43:46 -0700 Received: (qmail 17048 invoked from network); 23 Aug 2005 03:43:26 -0000 Received: from unknown (HELO ?192.168.0.3?) (unknown) by unknown with SMTP; 23 Aug 2005 03:43:26 -0000 X-pair-Authenticated: 24.4.253.245 Message-ID: <430A9B61.4020700@electricjellyfish.net> Date: Mon, 22 Aug 2005 20:43:29 -0700 From: Garrett Rooney User-Agent: Mozilla Thunderbird 1.0.6 (X11/20050727) X-Accept-Language: en-us, en MIME-Version: 1.0 To: dev@httpd.apache.org Subject: Re: svn commit: r239318 - /httpd/mod_smtpd/trunk/smtp_core.c References: <20050823033858.13324.qmail@minotaur.apache.org> In-Reply-To: <20050823033858.13324.qmail@minotaur.apache.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N soc-rian@apache.org wrote: > Author: soc-rian > Date: Mon Aug 22 20:38:56 2005 > New Revision: 239318 > > URL: http://svn.apache.org/viewcvs?rev=239318&view=rev > Log: > Made smtpd_run_queue a RUN_ALL hook (so multiple plugins can handle the message) This is another example of a change that makes numerous unrelated whitespace changes which obscure the actual change in functionality, making it difficult to read. I don't have any particular objection to the whitespace changes, but they should have been made in a separate commit. This kind of thing only takes a little bit of effort on your part, but it makes it far far easier (and thus more likely) for other developers to review the change and verify that it is correct. -garrett