httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: [PATCH] Make caching hash more deterministic
Date Fri, 12 Aug 2005 17:34:50 GMT

On Aug 12, 2005, at 1:10 PM, Colm MacCarthaigh wrote:

> On Fri, Aug 12, 2005 at 04:59:20PM +0100, Colm MacCarthaigh wrote:
>
>> On Fri, Aug 12, 2005 at 11:54:44AM -0400, Brian Akins wrote:
>>
>>> Should this honor usecanonicalname?  If so, could just use
>>> ap_get_servername(r) in stead of r->hostname.  This may further  
>>> compact
>>> the number of entries.
>>>
>>
>> Yes, but I think there'd have to be additional code to detect the  
>> proxy
>> cases. And you pointing that out has just reminded me of a bug in my
>> patch - it doesn't work for;
>>
>>     GET ftp://ftp.heanet.ie/pub/heanet/100.txt HTTP/1.0
>>
>> I'll go make that work too.
>>
>
> Here's a more involved patch that gets the logic right. It's 6pm on a
> Friday for me, so I have only tested it a little, but thought I'd  
> share
> for comment before the weekend.
>

+1 on inspection... testing to be done over
the weekend :)

Mime
View raw message