httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: svn commit: r230733 - /httpd/httpd/trunk/modules/proxy/mod_proxy_http.c
Date Tue, 09 Aug 2005 16:40:36 GMT
At 04:38 AM 8/9/2005, Joe Orton wrote:

>Great, yes with last night's regression run the segfaults with worker 
>were gone and the tests are all passing for prefork and worker again on 
>the trunk - thanks a lot Bill.  -Werror builds are failing though:
>
>mod_proxy_http.c: In function `ap_proxy_http_request':
>mod_proxy_http.c:312: warning: 'status' might be used uninitialized in 
>this function

Does this patch resolve status for your compiler's -Werror?
(already committed to trunk, will hold off on proxyreq-2.0.x
till I hear back.)

--- httpd/httpd/trunk/modules/proxy/mod_proxy_http.c (original)
+++ httpd/httpd/trunk/modules/proxy/mod_proxy_http.c Tue Aug  9 07:54:46 2005
@@ -949,7 +949,8 @@
                                               || (bytes_read > 0));
         break;
     default:
-        ap_assert(1 != 1);
+        /* shouldn't be possible */
+        status = APR_EINVAL;
         break;
     }
 



Mime
View raw message