httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <>
Subject [SubPatches] httpd-2.0.54-proxy-request.patch
Date Sun, 07 Aug 2005 02:53:26 GMT
Contained in the patch at

are significantly insignificant changes which I'll entertain
separate votes to commit (one commit per bullet, below) resulting
in a smaller patch to consider for the handling of request bodies:

 * change the indention level to an appropriate amount following
       for (counter = 0; counter < headers_in_array->nelts; counter++) {
   which will be a whitespace only change

 * eliminate redundant tests of headers_in[counter].key == NULL 
   and headers_in[counter].val == NULL as this was tested immediately 
   after the line
       for (counter = 0; counter < headers_in_array->nelts; counter++) {

 * replace the bogus abuse of apr_strnatcasecmp with strcasecmp

I believe the resulting patch following these three commits will
be somewhat simpler for folks to review.  Please vote.


   (don't set up else code blocks following an if case which
   results in an absolute 'return', especially when we were
   breaking 80-col limits left and right)


View raw message