httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Akins <>
Subject Re: [PATCH] mod_disk_cache: speed up read_table
Date Thu, 18 Aug 2005 17:49:09 GMT
Justin Erenkrantz wrote:

> None of the code in mod_disk_cache used buffering before I turned it 
> on.  It gave significant speedups in my performance tests by reducing 
> the syscall overhead.  I also had identified and fixed some bugs in 
> apr's buffering code to go along with these speedups that went out in 
> APR 1.0.1.  So, unless the profiles have changed (unlikely), removing 
> buffering is a bad idea.  -- justin

Colm's idea would eliminate the need for the buffering as it would read 
the entire headers file in at one time and manipulate the memory in 
place.  In this case buffering would actually hurt performance as it 
would have lots of extra memcpy's.

Brian Akins
Lead Systems Engineer
CNN Internet Technologies

View raw message