httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Akins <brian.ak...@turner.com>
Subject Re: [PATCH] mod_disk_cache: speed up read_table
Date Thu, 18 Aug 2005 14:43:41 GMT
Colm MacCarthaigh wrote:

> I can understand why this is faster, I'm guessing that you've enough RAM
> that you're retrieving files from the vmcache and that the higher-layer
> buffering is just overhead. This is probably going to be the majority
> case, but would do with testing.

Not to heap more configuration into it, but this could also be configurable.

> It's not nearly as neat a patch, but including the lengths of the tables
> in the cache_info_t object is doable, and in fact would allow for
> decreasing the number of read()'s to just 3. One for the format, one
> more for the cache_info_t, and one more the tables. This would probably
> produce another similar speed improvement.

That's what I wanted to do, but it was messy.  I would like to have the 
length of resp_hdrs, req_hdrs, and the data (would save a stat...) in 
the disk_cache_info_t, but that is a much more major thing from what I 
can tell.

Basically would have to rearrange store_headers completely...


>>-#if APR_CHARSET_EBCDIC
> 
> 
> Well that won't fly ;-)
> 

I know, I know :)  I just wanted to get the idea out there without 
having to muck with that.  Obviously the final patch should consider 
EBDCID as well.


-- 
Brian Akins
Lead Systems Engineer
CNN Internet Technologies

Mime
View raw message