httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject Re: [PATCH] fix incorrect 304's responses when cache is unwritable
Date Mon, 08 Aug 2005 19:46:52 GMT

Colm MacCarthaigh wrote:
> On Mon, Aug 08, 2005 at 10:33:47AM +0200, wrote:


> O.k., I've merged our two patches, but I've changed a few things, tell
> me if there's anothing you think is wrong;

I attached two further patches to your merged patch:


This moves the debuging log message about the removal of a url from cache_remove_url_filter
to cache_remove_url.
Reason: It is not a good idea to use f->r->unparsed_uri for the log message as this
will display not the url that gets removed from the cache, but the url of the error document
(at least in some case) and thus is misleading.
Therefore I moved it to cache_remove_url and take h->cache_obj->key instead for
the debug message.


This patch will remove the directory path of the cached file as far as possible to get rid
of unused empty directories. And yes, I trust apr_dir_remove :-).




View raw message