httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andreas Steinmetz <...@domdv.de>
Subject Re: [PATCH] add "remove empty directories" option to htcacheclean
Date Mon, 08 Aug 2005 10:41:56 GMT
Colm MacCarthaigh wrote:
> On Mon, Aug 08, 2005 at 12:04:44AM +0100, Colm MacCarthaigh wrote:
> 
>>Well that's a pretty each race to solve within httpd. It won't be able
>>to create the headers, or the body. The patch I've submitted cleans up
>>that slight race. The file won't be cached on that serve, but I don't
>>think that's a big deal :-)

Up to the apache maintainers to decide. One question, though. Why do you
 introduce directory_empty()? A blind call to apr_dir_remove() should be
sufficient. It will fail if the directory is not empty and succeed if it is.
-- 
Andreas Steinmetz                       SPAMmers use robotrap@domdv.de

Mime
View raw message