httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r.pl...@t-online.de
Subject Re: [PATCH] fix incorrect 304's responses when cache is unwritable
Date Sun, 07 Aug 2005 19:59:15 GMT


Colm MacCarthaigh wrote:
> I finally developed some time to look into this. mod_cache doesn't
> behave very nicely when the cache area fills. Of course administators
> should make sure it doesn't fill in the first place, but nevertheless a
> few people have hit this bug (me included) and I think mod_cache should
> handle the problem gracefully.
> 
> Anyway, the problem occurs when the cache is unwritable, and mod_cache
> needs to revalidate a cached entity. cache_select_url handles this by
> rewriting headers_in to become a conditional request. However the code
> in cache_save_filter which turns the request back into its original
> (possibly unconditional) format is itself conditional on store_headers()
> working. 
> 
> The patch I've attached should be reasonably self-documenting, any
> questions - just ask. 
> 

As you already mentioned the remove_url implementation
of mod_disk_cache is currently an empty dummy :-).

I had a similar problem with 404 responses, and wrote a patch for this which is
currently in discussion (attached patch again to this mail):

http://mail-archives.apache.org/mod_mbox/httpd-dev/200507.mbox/%3c42DF9B4C.5080604@apache.org%3e

It actually does implement a removal of the files in mod_disk_cache and
should also handle your problem. If it does not, I am pretty sure that a small modification
to the patch would do it.

I would really appreciate if you find some time to review my patch.

Thanks and regards

RĂ¼diger

Mime
View raw message