httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: svn commit: r239711 - /httpd/httpd/trunk/server/mpm/prefork/prefork.c
Date Wed, 24 Aug 2005 19:21:35 GMT
On Wed, Aug 24, 2005 at 08:18:35PM +0100, Colm MacCarthaigh wrote:
> On Wed, Aug 24, 2005 at 08:08:51PM +0100, Joe Orton wrote:
> > On Wed, Aug 24, 2005 at 12:02:37PM -0700, Justin Erenkrantz wrote:
> > > --On August 24, 2005 4:58:14 PM +0000 colm@apache.org wrote:
> > > >This means that the listening sockets are freed for re-use. In the
> > > >ordinary case, this makes no difference. However if for example admin
> > > >changes "Listen 80" to "Listen 81" in the config, this rev makes port 80
> > > >immediately available (no waiting for the graceful children to die).
> > > 
> > > Looks fine.  However, this is probably worth a CHANGES entry.
> > 
> > Especially since you win a free PR with this fix :)
> > 
> > http://issues.apache.org/bugzilla/show_bug.cgi?id=28167
> 
> It's not fixed *just* yet, only in prefork, and the PR reporter was
> using worker. I had found the PR ;)

Duh, I missed that, sorry.

> I'm testing worker now. Is fixing it in the non-experimental MPM's
> enough to note it as fixed in the CHANGES file, or should I list the
> MPM's?

Having a CHANGES entry which explains the fix is limited to whatever set 
of MPMs sounds fine to me.

joe

Mime
View raw message