httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Colm MacCarthaigh <>
Subject Re: [PATCH] mod_disk_cache: speed up read_table
Date Thu, 18 Aug 2005 17:51:21 GMT
On Thu, Aug 18, 2005 at 10:43:45AM -0700, Justin Erenkrantz wrote:
> None of the code in mod_disk_cache used buffering before I turned it on.  
> It gave significant speedups in my performance tests by reducing the 
> syscall overhead.  I also had identified and fixed some bugs in apr's 
> buffering code to go along with these speedups that went out in APR 1.0.1.  
> So, unless the profiles have changed (unlikely), removing buffering is a 
> bad idea.  -- justin

The optimisations wouldn't be removing buffering, they'd be using a
different kind of buffering :-) If MMap is not available/enabled we can
fail back to a buffered APR read.

Colm MacCárthaigh                        Public Key:

View raw message