httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Colm MacCarthaigh <c...@stdlib.net>
Subject Re: [PATCH] add "remove empty directories" option to htcacheclean
Date Mon, 08 Aug 2005 11:08:53 GMT
On Mon, Aug 08, 2005 at 12:41:56PM +0200, Andreas Steinmetz wrote:
> Colm MacCarthaigh wrote:
> > On Mon, Aug 08, 2005 at 12:04:44AM +0100, Colm MacCarthaigh wrote:
> > 
> >>Well that's a pretty each race to solve within httpd. It won't be able
> >>to create the headers, or the body. The patch I've submitted cleans up
> >>that slight race. The file won't be cached on that serve, but I don't
> >>think that's a big deal :-)
> 
> Up to the apache maintainers to decide. One question, though. Why do you
>  introduce directory_empty()? A blind call to apr_dir_remove() should be
> sufficient. It will fail if the directory is not empty and succeed if it is.

See my other comments about APR not claiming to ensure this behaviour.

-- 
Colm MacCárthaigh                        Public Key: colm+pgp@stdlib.net

Mime
View raw message