httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <jus...@erenkrantz.com>
Subject Re: mod_cache recall_body
Date Thu, 18 Aug 2005 17:10:46 GMT
--On August 18, 2005 9:55:57 AM -0400 Brian Akins <bakins@web.turner.com> 
wrote:

> Why do we pass request_rec to recall_headers, but not to recall_body. We
> also always pass r->pool.  How horrible would it be if the prototype was
> changed to:
>
> apr_status_t (*recall_body) (cache_handle_t *h, request_rec
> *r,apr_bucket_brigade *bb);
>
> I wanted to get r in recall_body so mod_disk_cache could honor EnableMMap.
> open_entity can already be modified to honor EnableSendfile fairly easily.

I'd be fine with it matching store_body's prototype.  (Which is what you 
have.)  -- justin

Mime
View raw message