Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (asf.osuosl.org: domain of jorton@redhat.com designates
 66.187.233.31 as permitted sender)
Date: Fri, 22 Jul 2005 13:18:21 +0100
From: Joe Orton <jorton@redhat.com>
To: dev@httpd.apache.org
Subject: Re: svn commit: r220307 - in /httpd/httpd/trunk/modules:
 metadata/mod_setenvif.c ssl/mod_ssl.c ssl/mod_ssl.h ssl/ssl_expr_eval.c
Message-ID: <20050722121821.GB19040@redhat.com>
Mail-Followup-To: dev@httpd.apache.org
References: <20050722121157.22343.qmail@minotaur.apache.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20050722121157.22343.qmail@minotaur.apache.org>
User-Agent: Mutt/1.4.2.1i

On Fri, Jul 22, 2005 at 12:11:56PM -0000, Martin Kraemer wrote:
> Author: martin
> Date: Fri Jul 22 05:11:55 2005
> New Revision: 220307
> 
> URL: http://svn.apache.org/viewcvs?rev=220307&view=rev
> Log:
> Allow extraction of the values of SSL certificate extensions into
> environment variables, so that their value can be used by any
> module that is aware of environment variables, as in:

So what is the point in posting patches for review if you don't actually 
wait for anyone to review them before committing?

>   SetEnvIf OID("2.16.840.1.113730.1.13") "(.*) Generated (Certificate)" ca=$1

-1 on the naming since OID is completely entirely meaningless in this 
context.

mod_setenvif.c:
>  module AP_MODULE_DECLARE_DATA setenvif_module;
> +#if (MODULE_MAGIC_NUMBER_MAJOR > 20020903)
> +#include "mod_ssl.h"

unnecessary for trunk code to care about the MMN, it can always rely on 
mod_ssl.h being available.

mod_ssl.h:
> +extern apr_array_header_t *ssl_extlist_by_oid(request_rec *r, const char *oidstr);

and don't export the function as well as the optional function.