Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 35306 invoked from network); 8 Jul 2005 06:49:01 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 8 Jul 2005 06:49:01 -0000 Received: (qmail 22841 invoked by uid 500); 8 Jul 2005 06:48:54 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 22607 invoked by uid 500); 8 Jul 2005 06:48:53 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 22594 invoked by uid 99); 8 Jul 2005 06:48:53 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Jul 2005 23:48:53 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of jorton@redhat.com designates 66.187.233.31 as permitted sender) Received: from [66.187.233.31] (HELO mx1.redhat.com) (66.187.233.31) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Jul 2005 23:48:51 -0700 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j686moaX027611 for ; Fri, 8 Jul 2005 02:48:50 -0400 Received: from radish.cambridge.redhat.com (radish.cambridge.redhat.com [172.16.18.90]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j686mlV00886 for ; Fri, 8 Jul 2005 02:48:49 -0400 Received: (from jorton@localhost) by radish.cambridge.redhat.com (8.13.4/8.13.4/Submit) id j686mkfq013290 for dev@httpd.apache.org; Fri, 8 Jul 2005 07:48:46 +0100 X-Authentication-Warning: radish.cambridge.redhat.com: jorton set sender to jorton@redhat.com using -f Date: Fri, 8 Jul 2005 07:48:46 +0100 From: Joe Orton To: dev@httpd.apache.org Subject: Re: [Patch 2.0] d2i_SSL_SESSION args for 0.9.7f-/0.9.7g/0.9.8 Message-ID: <20050708064846.GA13209@redhat.com> Mail-Followup-To: dev@httpd.apache.org References: <6.2.1.2.2.20050707172833.0667dd60@pop3.rowe-clan.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <6.2.1.2.2.20050707172833.0667dd60@pop3.rowe-clan.net> User-Agent: Mutt/1.4.2.1i X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N On Thu, Jul 07, 2005 at 06:51:04PM -0500, William Rowe wrote: > Attached is a backport of rev 209530, which demanded a little > bit of rework to make it functional. > > This resolves build issues which caused errors in 0.9.7f and > prior on Win32 and build failures on Netware. This patch > correctly chooses the appropriate const-ness for 0.9.6, 0.9.7, > or 0.9.8 OpenSSL. It needs to be verified on Netware since > my Win32 builds completely clean. -1, this is barely readable, using a #define as previously or a typedef in ssl_toolkit_compat.h is much cleaner. joe