Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 23130 invoked from network); 6 Jul 2005 18:22:49 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 6 Jul 2005 18:22:49 -0000 Received: (qmail 26199 invoked by uid 500); 6 Jul 2005 18:22:42 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 26151 invoked by uid 500); 6 Jul 2005 18:22:42 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 26136 invoked by uid 99); 6 Jul 2005 18:22:41 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Jul 2005 11:22:41 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of jorton@redhat.com designates 66.187.233.31 as permitted sender) Received: from [66.187.233.31] (HELO mx1.redhat.com) (66.187.233.31) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Jul 2005 11:22:41 -0700 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j66IMbSg001930; Wed, 6 Jul 2005 14:22:37 -0400 Received: from radish.cambridge.redhat.com (radish.cambridge.redhat.com [172.16.18.90]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j66IMbV05046; Wed, 6 Jul 2005 14:22:37 -0400 Received: (from jorton@localhost) by radish.cambridge.redhat.com (8.13.4/8.13.4/Submit) id j66IMZrD024952; Wed, 6 Jul 2005 19:22:35 +0100 X-Authentication-Warning: radish.cambridge.redhat.com: jorton set sender to jorton@redhat.com using -f Date: Wed, 6 Jul 2005 19:22:35 +0100 From: Joe Orton To: "William A. Rowe, Jr." Cc: dev@httpd.apache.org Subject: Re: [Patch 1.3] Strict proxy C-L / T-E conformance Message-ID: <20050706182235.GB24568@redhat.com> Mail-Followup-To: "William A. Rowe, Jr." , dev@httpd.apache.org References: <6.2.1.2.2.20050705223346.0befdd30@pop3.rowe-clan.net> <6.2.1.2.2.20050705224755.0c763060@pop3.rowe-clan.net> <791E8E0E-9F75-4369-BBAF-8957E181FCED@jaguNET.com> <6.2.1.2.2.20050706085046.08347580@pop3.rowe-clan.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <6.2.1.2.2.20050706085046.08347580@pop3.rowe-clan.net> User-Agent: Mutt/1.4.2.1i X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N On Wed, Jul 06, 2005 at 11:45:21AM -0500, William Rowe wrote: ... > + else { > + char *len_end; > + errno = 0; > + c->len = ap_strtol(content_length, &len_end, 10); ... > + if (errno || (c->len < 0) || (len_end && *len_end)) { You should copy the logic used on the trunk to get the correct tests for a strtol parse error: errno || len_end == content_length || *len_end || c->len < 0 joe