Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (asf.osuosl.org: domain of rian@mit.edu designates
 18.7.7.80 as permitted sender)
Message-ID: <1120232065.42c562813064e@webmail.mit.edu>
Date: Fri,  1 Jul 2005 11:34:25 -0400
From: Rian A Hunter <rian@MIT.EDU>
To: dev@httpd.apache.org
Subject: Re: mod_smtpd design.
References: <42C4E643.10806@mit.edu> <42C503FA.9000809@algroup.co.uk>
 <42C547FE.2050708@mit.edu> <42C5522E.7000107@electricjellyfish.net>
In-Reply-To: <42C5522E.7000107@electricjellyfish.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
User-Agent: Internet Messaging Program (IMP) 3.2.2

Quoting Garrett Rooney <rooneg@electricjellyfish.net>:
> Rian Hunter wrote:
> > type misc_smtp_handler(request_rec *r) {
> >     smtpd_request_rec *smtp_data;
> > 
> >     if (strncmp("http", r->protocol_name, 4)) {
> >         // decline to handle, this module doesn't handle
> >         // http requests.
> >     }
> >     //then get smtpd specific data
> >     smtp_data = get_smtpd_request(r);
> > 
> >     // do some handlin'
> > }
> > 
> > The advantage to this approach is a less bulky (but more all 
> > encompassing) request_rec with support for an arbitrary amount of 
> > protocols and protocol specific data.
> 
> Rather than inserting dozens of strcmps all throught the processing, I'd 
> prefer to store an int identifying the protocol, and just have a simple 
> compare.  No reason to burn CPU on the strcmp if we don't have to.
> 
> -garrett
> 

The reason I suggested a strcmp is that it gives freedom to module developers to
set and implement any protocol they like. Doing integer comparisons would
require us to maintain a list of "official" integer->protocol mappings, but
there may be other ways to approach it without having that constraint. Maybe we
can use the official iana port description list to specifiy protocols like 80
means http, 25 means smtp, 143 means imap etc.
-rian