httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: [vote(s)] [Patch 1.3] Strict proxy C-L / T-E conformance
Date Mon, 11 Jul 2005 14:14:40 GMT
At 03:42 PM 7/9/2005, Jim Jagielski wrote:

>On Jul 8, 2005, at 10:45 PM, William A. Rowe, Jr. wrote:
>
>>[22 hours - ping]
>>
>>Votes please?  2/3 of our users use 1.3, do you?
>>
>>Jim reminded me we don't ap_strtol everywhere, so the NULL check
>>I guess remains a good idea, as would a (len_end == content_length)
>>test which I will add before committing.
>
>For some reason I'd feel safer with
>
>    ap_proxy_send_fb(f, r, c, c->len, 0, (chunked ? 1 : 0), conf- >io_buffer_size);

I'm partial to (chunked != NULL) myself - also evaluates to 1 bit 
boolean.


>Other than that nit, +1

I'll change before I commit, if I can get one more Ack :)

Bill




Mime
View raw message