httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: [Patch 2.0] d2i_SSL_SESSION args for 0.9.7f-/0.9.7g/0.9.8
Date Fri, 08 Jul 2005 14:53:44 GMT

>At 01:48 AM 7/8/2005, Joe Orton wrote:
>>On Thu, Jul 07, 2005 at 06:51:04PM -0500, William Rowe wrote:
>>> 
>>> This resolves build issues which caused errors in 0.9.7f and
>>> prior on Win32 and build failures on Netware.  This patch
>>> correctly chooses the appropriate const-ness for 0.9.6, 0.9.7,
>>> or 0.9.8 OpenSSL.  It needs to be verified on Netware since
>>> my Win32 builds completely clean.
>>
>>-1, this is barely readable, using a #define as previously or a typedef 
>>in ssl_toolkit_compat.h is much cleaner.

Ok, attached is a const-flag based solution buried back into
ssl_toolkit_compat.h, that I believe is the most readable.

Comments/Votes?  2.0.x patch attached; 2.1 committed.

Bill

Mime
View raw message