httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Paul Querna <c...@force-elite.com>
Subject Re: svn commit: r208787 - in /httpd/httpd/trunk/modules: http/http_filters.c http/http_protocol.c proxy/mod_proxy.c
Date Wed, 06 Jul 2005 23:30:49 GMT
Justin Erenkrantz wrote:

> --On July 4, 2005 11:08:18 PM -0500 "William A. Rowe, Jr." 
> <wrowe@rowe-clan.net> wrote:
>
>>>  It still is not 'correct' until REQUEST_CHUNKED_PASS is reimplemented
>>>  and passes some chunk headers, since we aren't echoing the entire
>>>  request.  But it gets me further on testing 1.3 -> 2.0 -> 2.1 -> 
>>> 2.0 ->
>>>  1.3 proxy behaviors.
>>
>
> As I've said before, REQUEST_CHUNKED_PASS needs to go away in 2.x.  
> The correct 'fix' is to remove the CHUNK input filter and then call 
> ap_get_brigade().  But, calling ap_should_client_block, 
> ap_get_client_block(), etc. is just flat-out wrong for 2.x.  -- justin


Then we should remove them from trunk today.  Why leave a 'flat-out 
wrong' API available?



Mime
View raw message