httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: [patch 1.3] The http_protocol.c C-L + T-E patch
Date Tue, 19 Jul 2005 21:11:55 GMT
On Tue, Jul 19, 2005 at 02:59:14PM -0500, William Rowe wrote:
> Paul?  Joe?  Jeff?  Someone?
> 
> This is the only showstopper to a 1.3.34 candidate today, 
> since 1.3.x/src/modules/proxy/mod_proxy.c rejects T-E 
> for proxy request bodies.

Since the 1.3 proxy already rejects such requests what does this patch 
actually fix?

> 
> Bill
> 
> At 03:26 PM 7/15/2005, William A. Rowe, Jr. wrote:
> >folks, the same patch Paul/Joe worked out for 2.1, then 2.0,
> >should still probably fall on 1.3 even though proxy is not
> >affected.  Other modules surely could be hit.
> >
> >Votes/Comments?  I think this is it for getting 1.3.34 out.
> >
> >Index: src/main/http_protocol.c
> >===================================================================
> >--- src/main/http_protocol.c    (revision 209835)
> >+++ src/main/http_protocol.c    (working copy)
> >@@ -1214,6 +1214,14 @@
> >             ap_log_transaction(r);
> >             return r;
> >         }
> >+        if (ap_table_get(r->headers_in, "Transfer-Encoding")
> >+            && ap_table_get(r->headers_in, "Content-Length")) {
> >+            /* 2616 section 4.4, point 3: "if both Transfer-Encoding
> >+             * and Content-Length are received, the latter MUST be
> >+             * ignored"; so unset it here to prevent any confusion
> >+             * later. */
> >+            ap_table_unset(r->headers_in, "Content-Length");
> >+        }
> >     }
> >     else {
> >         ap_kill_timeout(r);
> 

Mime
View raw message