httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: [vote(s)] [Patch 1.3] Strict proxy C-L / T-E conformance
Date Sat, 09 Jul 2005 20:42:00 GMT

On Jul 8, 2005, at 10:45 PM, William A. Rowe, Jr. wrote:

> [22 hours - ping]
>
> Votes please?  2/3 of our users use 1.3, do you?
>
> Jim reminded me we don't ap_strtol everywhere, so the NULL check
> I guess remains a good idea, as would a (len_end == content_length)
> test which I will add before committing.
>


I see:

   * content length is not known. We need to make 100% sure c->len is  
always
   * set correctly before we get here to correctly do keepalive.
   */
-        ap_proxy_send_fb(f, r, c, c->len, 0, chunked, conf- 
 >io_buffer_size);
+        ap_proxy_send_fb(f, r, c, c->len, 0, (int)chunked, conf- 
 >io_buffer_size);
      }


For some reason I'd feel safer with

     ap_proxy_send_fb(f, r, c, c->len, 0, (chunked ? 1 : 0), conf- 
 >io_buffer_size);

Other than that nit, +1

Mime
View raw message