Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (hermes.apache.org: domain of jorton@redhat.com designates
 66.187.233.31 as permitted sender)
Date: Thu, 9 Jun 2005 16:22:09 +0100
From: Joe Orton <jorton@redhat.com>
To: dev@httpd.apache.org
Subject: Re: svn commit: r189761 - /httpd/httpd/branches/fips-dev/acinclude.m4
Message-ID: <20050609152209.GA5278@redhat.com>
Mail-Followup-To: dev@httpd.apache.org
References: <20050609145737.20696.qmail@minotaur.apache.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20050609145737.20696.qmail@minotaur.apache.org>
User-Agent: Mutt/1.4.1i

On Thu, Jun 09, 2005 at 02:57:37PM -0000, ben@apache.org wrote:
> Author: ben
> Date: Thu Jun  9 07:57:36 2005
> New Revision: 189761
> 
> URL: http://svn.apache.org/viewcvs?rev=189761&view=rev
> Log:
> Die properly when path is bollocks.

Did you mean to commit this to the branch? (given that it's not
FIPS-specific)

- "test x == y" is not portable, s/==/=/
- don't exit, use AC_MSG_ERROR and pass an error message
- whitespace should be spaces not tabs

> Modified:
>     httpd/httpd/branches/fips-dev/acinclude.m4
> 
> Modified: httpd/httpd/branches/fips-dev/acinclude.m4
> URL: http://svn.apache.org/viewcvs/httpd/httpd/branches/fips-dev/acinclude.m4?rev=189761&r1=189760&r2=189761&view=diff
> ==============================================================================
> --- httpd/httpd/branches/fips-dev/acinclude.m4 (original)
> +++ httpd/httpd/branches/fips-dev/acinclude.m4 Thu Jun  9 07:57:36 2005
> @@ -340,7 +340,10 @@
>      dnl If --with-sslc specifies a directory, we use that directory or fail
>      if test "x$withval" != "xyes" -a "x$withval" != "x"; then
>        dnl This ensures $withval is actually a directory and that it is absolute
> -      ap_ssltk_base="`cd $withval ; pwd`"
> +      ap_ssltk_base="`cd $withval && pwd`"
> +      if test "x$ap_ssltk_base" == "x"; then
> +	exit
> +      fi
...