httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: Blocking Sockets? was Re: TCP_CORK broken on Linux 2.6?
Date Fri, 24 Jun 2005 23:05:07 GMT
On 6/24/05, Paul Querna <chip@force-elite.com> wrote:

dev@apr.apache.org...

> I thought we were always supposed to be using a blocking socket when
> doing the sendfile?

no
> Index: core_filters.c
> ===================================================================
> --- core_filters.c      (revision 201576)
> +++ core_filters.c      (working copy)
> @@ -845,6 +845,8 @@
>              return APR_SUCCESS;
>          }
> 
> +        apr_socket_opt_set(net->client_socket, APR_SO_NONBLOCK, 0);
> +

now you have a denial of service attack ;)  connect to Paul's web
server and park...

> Is our code for detection of inheriting non-blocking from the listening
> socket broken?

that doesn't pertain here...  listening sockets are non-blocking (to
deal with prematurely reset connection) ...  connected sockets are
non-blocking (to deal with timeouts in portable manner)...

Mime
View raw message