httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Paul Querna <c...@force-elite.com>
Subject Re: [PATCH] mod_disk_cache: Handling of Varied Content
Date Sun, 12 Jun 2005 20:57:00 GMT
Justin Erenkrantz wrote:

>On Sun, Jun 12, 2005 at 10:06:30AM -0700, Paul Querna wrote:
>  
>
>>I believe so.  Yes, it clutters the code, but my objective is to have a 
>>switch where I can easily add logging to the common case code, and leave 
>>it in there, instead of deleting it before I commit.  I think in the 
>>long run, we need a different log level for 'developer' debugging.  Just 
>>look at some of the stuff that the a reverse SSL Proxy logs at LogLevel 
>>Debug.
>>    
>>
>
>I would really prefer that we stick with placing these log entries at debug
>and address a 'developer' log level independently of this.  But, adding
>#ifdefs is not a solution.
>
>  
>
>>ap_get_list_item() returns them lower-cased, avoiding this whole issue.
>>    
>>
>
>Relying on lowercased header names is not enough.  In certain cases, the
>header *values* are supposed to be rendered case-insensitively as well
>(Accept-Encoding, etc.).  Yet, in other cases, the header values are supposed
>to be case-sensitive.  =)
>
>  
>
Ick.  Do you know of a magical list of which ones are case insensitive? 
(I mean, besides reading the RFC for every header..)

Actually, to be more correct, we should sort the values of the headers 
too.  Eg, for any client header that is separated by commas, we should 
sort those, into a known order, since they should generate the exact 
same response if it is also a varied header.

>This will mean that the cache will not hit when it should.  We *could* just
>punt on the values and cache multiple responses that are actually the same...
>  
>
This seems like an acceptable solution for now :)

-Paul

Mime
View raw message