httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@algroup.co.uk>
Subject Re: svn commit: r189761 - /httpd/httpd/branches/fips-dev/acinclude.m4
Date Thu, 09 Jun 2005 15:47:38 GMT
Joe Orton wrote:
> On Thu, Jun 09, 2005 at 02:57:37PM -0000, ben@apache.org wrote:
> 
>>Author: ben
>>Date: Thu Jun  9 07:57:36 2005
>>New Revision: 189761
>>
>>URL: http://svn.apache.org/viewcvs?rev=189761&view=rev
>>Log:
>>Die properly when path is bollocks.
> 
> 
> Did you mean to commit this to the branch? (given that it's not
> FIPS-specific)

Well, I should probably also commit to the head, its true. But I hope 
the long-term plan will be to take the whole FIPS branch to head.

> - "test x == y" is not portable, s/==/=/

OK.

> - don't exit, use AC_MSG_ERROR and pass an error message

OK. autoconf sucks.

> - whitespace should be spaces not tabs

OK.

-- 
 >>>ApacheCon Europe<<<                   http://www.apachecon.com/

http://www.apache-ssl.org/ben.html       http://www.thebunker.net/

"There is no limit to what a man can do or how far he can go if he
doesn't mind who gets the credit." - Robert Woodruff

Mime
View raw message