httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r.pl...@t-online.de
Subject Re: problems w/ geronimo wiki (cache???)
Date Tue, 07 Jun 2005 21:55:24 GMT


Justin Erenkrantz wrote:
> --On Tuesday, June 7, 2005 11:42 PM +0200 r.pluem@t-online.de wrote:
> 
>> Sorry, if this is a stupid quickshot, but what about something like:
> 
> 
> Nope, it's not stupid as that's about the only sane place I can think of
> sticking it as well.  The only catch is that if a handler exits this
> way, it probably means that r->status isn't correct either.  So, perhaps
> we also set r->status explicitly in this additional code path.  -- justin
> 

Yes you are right I forgot this. So I think this would be better:

--- config.c.orig       2005-05-26 10:35:57.000000000 +0200
+++ config.c    2005-06-07 23:54:17.000000000 +0200
@@ -375,6 +375,18 @@ AP_CORE_DECLARE(int) ap_invoke_handler(r
             "handler \"%s\" not found for: %s", r->handler, r->filename);
     }

+    if (!r->eos_sent && (result != DECLINED)) {
+        apr_bucket_brigade *bb;
+        apr_bucket *e;
+
+        r->status = result;
+        bb = apr_brigade_create(r->pool, r->connection->bucket_alloc);
+        e = apr_bucket_eos_create(r->connection->bucket_alloc);
+        APR_BRIGADE_INSERT_TAIL(bb, e);
+
+        return ap_pass_brigade(r->output_filters, bb);
+    }
+
     return result == DECLINED ? HTTP_INTERNAL_SERVER_ERROR : result;
 }

Regards

RĂ¼diger

Mime
View raw message