httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Havard" <bri...@kheldar.apana.org.au>
Subject Re: svn commit: r169535 - /httpd/httpd/branches/1.3.x/src/modules/standard/mod_log_forensic.c
Date Wed, 11 May 2005 13:39:15 GMT
On Tue, 10 May 2005 23:36:57 -0000, wrowe@apache.org wrote:

[...]

>+const char * get_forensic_id(pool *p)
>+{
>+    static APACHE_TLS next_id = 0;
>+
>+    /* we make the assumption that we can't go through all the PIDs in
>+       under 1 second */
>+#ifdef MULTITHREAD
>+    return ap_psprintf(p, "%x:%lx:%x", getpid(), time(NULL), next_id++);
>+#else
>+    return ap_psprintf(p, "%x:%x:%lx:%x", getpid(), gettid(), time(NULL), next_id++);
>+#endif

Isn't the logic backwards here? I'd expect gettid() to be used only if
MULTITHREAD is defined.

This fails to build on OS/2 as there's no gettid(), even though MULTITHREAD
is not defined.

-- 
 ______________________________________________________________________________
 |  Brian Havard                 |  "He is not the messiah!                   |
 |  brianh@kheldar.apana.org.au  |  He's a very naughty boy!" - Life of Brian |
 ------------------------------------------------------------------------------


Mime
View raw message