httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: [PATCH] piped_log_spawn leaks an fd
Date Wed, 18 May 2005 14:05:39 GMT
On Tue, May 17, 2005 at 08:55:24AM -0400, Jeff Trawick wrote:
> On 5/16/05, Joe Orton <jorton@redhat.com> wrote:
> > It's the month of the piped loggers... there's another issue in this
> > code (just had the report this morning, by coincidence), that each time
> > a piped logger is spawned (or respawned), an fd is leaked.
> 
> +1 (reviewed, tested)

thanks!

> These recent fixes need to make it into 2.0.next as well.  This fix is
> apparently not necessary with 1.3.  1.3 with my patch to close the
> read side of the pipe in the children:

Yeah, 1.3 doesn't do the weird thing creating the second pipe and then
dup2()ing the original pipe fds into the new ones.  I don't know if
there's any real reason that's done or just some fallout from the way
the APR API works.  It would seem simpler to at least just dup() the
original fds instead and avoid the second pipe() call.

I've submitted backports for the last three commits to log.c.

joe

Mime
View raw message