httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <>
Subject Re: [PATCH] PR 26467 child process can hang when piped logger goes away
Date Mon, 16 May 2005 15:58:50 GMT
On Sun, May 15, 2005 at 08:22:32PM -0400, Jeff Trawick wrote:
> On 5/15/05, Joe Orton <> wrote:
> > I think it would be OK to make the behaviour change for 2.2 at least,
> > since the current behaviour of losing log entries during graceful
> > restart if using piped loggers is definitely Surprising Behaviour (tm).
> That's probably MUCH more practical than waiting until the current
> generation is finished to send SIGTERM, but the latter could be put to
> use in other circumstances.  (But no round tuits in sight for that.)

Actually the hard part of changing to "piped loggers are allowed to
exist until the pipe closes" is just doing the pipe-read-side-closure
cleanup which you've just committed.  (and works great, btw, just did
some testing)

So I think that now we could just remove the apr_proc_kill() call from
piped_log_maintenance() and it would all Just Work, right?  I'll try
this out later...


View raw message