Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 17233 invoked from network); 17 Apr 2005 22:31:01 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 17 Apr 2005 22:31:01 -0000 Received: (qmail 90443 invoked by uid 500); 17 Apr 2005 22:30:54 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 90409 invoked by uid 500); 17 Apr 2005 22:30:54 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 90395 invoked by uid 99); 17 Apr 2005 22:30:53 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: local policy) Received: from scorpio.lunarpages.com (HELO scorpio.lunarpages.com) (64.235.234.122) by apache.org (qpsmtpd/0.28) with ESMTP; Sun, 17 Apr 2005 15:30:52 -0700 Received: from ip70-187-185-149.oc.oc.cox.net ([70.187.185.149] helo=[192.168.0.101]) by scorpio.lunarpages.com with esmtpsa (TLSv1:RC4-SHA:128) (Exim 4.50) id 1DNIHy-0005ip-DZ for dev@httpd.apache.org; Sun, 17 Apr 2005 15:30:50 -0700 Mime-Version: 1.0 (Apple Message framework v622) In-Reply-To: <20050417202558.98771.qmail@minotaur.apache.org> References: <20050417202558.98771.qmail@minotaur.apache.org> Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <753842f4fb5ec765b8f271af66e26367@gbiv.com> Content-Transfer-Encoding: 7bit From: Roy T. Fielding Subject: mod_deflate setting Vary Date: Sun, 17 Apr 2005 15:30:47 -0700 To: dev@httpd.apache.org X-Mailer: Apple Mail (2.622) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - scorpio.lunarpages.com X-AntiAbuse: Original Domain - httpd.apache.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - gbiv.com X-Source: X-Source-Args: X-Source-Dir: X-Virus-Checked: Checked X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N On Apr 17, 2005, at 1:25 PM, pquerna@apache.org wrote: > + > + *) mod_deflate: Merge the Vary header, isntead of Setting it. Fixes > + applications that send the Vary Header themselves, and also apply > + mod_defalte as an output filter. [Paul Querna] > > *) mod_rewrite: use buffered I/O for RewriteMap txt: files. This > can result in a major performance improvement when the files are > > Modified: httpd/httpd/trunk/modules/filters/mod_deflate.c > URL: > http://svn.apache.org/viewcvs/httpd/httpd/trunk/modules/filters/ > mod_deflate.c?view=diff&r1=161690&r2=161691 > ======================================================================= > ======= > --- httpd/httpd/trunk/modules/filters/mod_deflate.c (original) > +++ httpd/httpd/trunk/modules/filters/mod_deflate.c Sun Apr 17 > 13:25:57 2005 > @@ -315,7 +315,7 @@ > * the Accept-Encoding, we need to note that we were looking > * for this header and downstream proxies should be aware of > that. > */ > - apr_table_setn(r->headers_out, "Vary", "Accept-Encoding"); > + apr_table_mergen(r->headers_out, "Vary", "Accept-Encoding"); Is deflate setting Vary here because it is changing the Content-Encoding, or is this part also done for Transfer-Encoding? It should not be setting Vary for changes to the Transfer-Encoding. ....Roy