Return-Path: 
 <dev-return-47040-apmail-httpd-dev-archive=httpd.apache.org@httpd.apache.org>
Delivered-To: apmail-httpd-dev-archive@www.apache.org
Received: (qmail 56966 invoked from network); 25 Apr 2005 18:02:49 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 25 Apr 2005 18:02:49 -0000
Received: (qmail 25164 invoked by uid 500); 25 Apr 2005 18:03:14 -0000
Delivered-To: apmail-httpd-dev-archive@httpd.apache.org
Received: (qmail 25114 invoked by uid 500); 25 Apr 2005 18:03:13 -0000
Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
list-help: <mailto:dev-help@httpd.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@httpd.apache.org>
List-Post: <mailto:dev@httpd.apache.org>
Delivered-To: mailing list dev@httpd.apache.org
Received: (qmail 25095 invoked by uid 99); 25 Apr 2005 18:03:13 -0000
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received-SPF: pass (hermes.apache.org: local policy)
Received: from force-elite.com (HELO utopia.in.force-elite.com)
 (216.255.199.145)
  by apache.org (qpsmtpd/0.28) with ESMTP; Mon, 25 Apr 2005 11:03:13 -0700
X-AuthUser: chip@force-elite.com
Received: from [10.0.0.142] (10.0.0.142:53182)
	by utopia.in.force-elite.com with [XMail 1.17 (Linux/Ix86) ESMTP Server]
	id <SAB6F8> for <dev@httpd.apache.org> from <chip@force-elite.com>;
	Mon, 25 Apr 2005 11:02:37 -0700
Message-ID: <426D30BD.8030105@force-elite.com>
Date: Mon, 25 Apr 2005 11:02:37 -0700
From: Paul Querna <chip@force-elite.com>
User-Agent: Mozilla Thunderbird 1.0.2 (Macintosh/20050317)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: dev@httpd.apache.org
Subject: Re: Proposed patch: always cleanup brigades in ap_pass_brigade
References: <9ccfb16df2220fc31c836bb7cd640554@ricilake.net>
In-Reply-To: <9ccfb16df2220fc31c836bb7cd640554@ricilake.net>
X-Enigmail-Version: 0.91.0.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

Rici Lake wrote:
> Regardless of any other changes to the brigade API, this seems to me to
> be a good idea:
> 

+1.  I agree, while the discussion on other 'rules' for brigades is
good, I think this patch should be applied regardless.

It seems all of the other discussion has revolved around the cleanup or
free()ing of brigades.

Several of our own filters rely upon the core input filter doing a
brigade_cleanup(), but with the current code, this is not guaranteed to
happen. Putting the brigade_cleanup at the end of ap_pass_brigade ensure
that our own filters don't accidentally break.

-Paul