httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Roy T. Fielding <field...@gbiv.com>
Subject mod_deflate setting Vary
Date Sun, 17 Apr 2005 22:30:47 GMT
On Apr 17, 2005, at 1:25 PM, pquerna@apache.org wrote:

> +
> +  *) mod_deflate: Merge the Vary header, isntead of Setting it. Fixes
> +     applications that send the Vary Header themselves, and also apply
> +     mod_defalte as an output filter. [Paul Querna]
>
>    *) mod_rewrite: use buffered I/O for RewriteMap txt: files.  This
>       can result in a major performance improvement when the files are
>
> Modified: httpd/httpd/trunk/modules/filters/mod_deflate.c
> URL:  
> http://svn.apache.org/viewcvs/httpd/httpd/trunk/modules/filters/ 
> mod_deflate.c?view=diff&r1=161690&r2=161691
> ======================================================================= 
> =======
> --- httpd/httpd/trunk/modules/filters/mod_deflate.c (original)
> +++ httpd/httpd/trunk/modules/filters/mod_deflate.c Sun Apr 17  
> 13:25:57 2005
> @@ -315,7 +315,7 @@
>           * the Accept-Encoding, we need to note that we were looking
>           * for this header and downstream proxies should be aware of  
> that.
>           */
> -        apr_table_setn(r->headers_out, "Vary", "Accept-Encoding");
> +        apr_table_mergen(r->headers_out, "Vary", "Accept-Encoding");

Is deflate setting Vary here because it is changing the
Content-Encoding, or is this part also done for Transfer-Encoding?

It should not be setting Vary for changes to the Transfer-Encoding.

....Roy


Mime
View raw message