httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject [RFC] error_log spam for immediately-closed connections
Date Thu, 28 Apr 2005 11:10:11 GMT
2.1 is logging a message for every connection which is closed with no
request sent: since that's exactly what the dummy_connection() does this
leaves a lot of weird-looking spam in the error_log when a server load
spike passes with prefork.

I think this should at least be downgraded to APLOG_DEBUG, where it
seems to defeat the original point of helping diagnose some type of DoS
(which could just as well be diagnosed by other means), so might as well
just be removed; 1.3/2.0 users did survive without it...

Index: server/protocol.c
===================================================================
--- server/protocol.c	(revision 165127)
+++ server/protocol.c	(working copy)
@@ -592,10 +592,6 @@
                 r->proto_num = HTTP_VERSION(1,0);
                 r->protocol  = apr_pstrdup(r->pool, "HTTP/1.0");
             }
-            else if (r->connection->keepalive != AP_CONN_KEEPALIVE) {
-                ap_log_rerror(APLOG_MARK, APLOG_INFO, rv, r,
-                              "Error while reading request line. (client didn't send a request?)");
-            }
             return 0;
         }
     } while ((len <= 0) && (++num_blank_lines < max_blank_lines));


Mime
View raw message